[PATCH] D87612: [llvm-readobj][test] - Improve section-symbols.test

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 07:31:32 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.

`section-symbols.test` tests how we print section symbols in
different situations.

We might have 2 different cases:

1. A named STT_SECTION symbol.
2. An unnamed STT_SECTION symbol.

Usually section symbols have no name and then `--symbols` uses their
section names when prints them. If symbol has a name, then it is used.

For `--relocations` we also want to have this logic probably,
but currently we always ignore symbol names and always use section names.
It is not consistent with GNU readelf and with our logic for `--symbols`.

This patch refines testing to document the existent behavior and improve
coverage.


https://reviews.llvm.org/D87612

Files:
  llvm/test/tools/llvm-readobj/ELF/section-symbols.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87612.291570.patch
Type: text/x-patch
Size: 6624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200914/b876a557/attachment.bin>


More information about the llvm-commits mailing list