[PATCH] D87453: [llvm-readobj/elf][test] - Test all core note types properly.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D87453#2270790 <https://reviews.llvm.org/D87453#2270790>, @jhenderson wrote:

> If you haven't already, could you run this test on Windows and make sure it doesn't take an unreasonable amount of time (since there are a lot of process executions, which are expensive on Windows), please. In theory, the test could be written with a single large input testing each individual value. This would make the test check/input bigger, but would at least avoid 150 or so process executions within a single test.

It takes 1.63s in debug configuration for me. (i7-4790K at 4.2 Ghz, windows 8.1 64, 32 Gb Ram, SSD).

  -- Testing: 1 tests, 1 workers --
  PASS: LLVM :: tools/llvm-readobj/ELF/note-core.test (1 of 1)
  
  Testing Time: 1.63s
    Passed: 1

Is it OK or too much?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87453/new/

https://reviews.llvm.org/D87453