[PATCH] D71786: [Support] On Windows, add optional support for {rpmalloc|snmalloc|mimalloc}

[Russell Gallop via Phabricator via llvm-commits]

russell.gallop added inline comments.


================
Comment at: llvm/CMakeLists.txt:570
 
+option(LLVM_INTEGRATED_CRT_ALLOC "Replace the Windows CRT allocator with any of {rpmalloc|mimalloc|snmalloc}. Only works with /MT enabled." OFF)
+if(LLVM_INTEGRATED_CRT_ALLOC)
----------------
"option" in cmake appears to create this as a BOOL option (https://cmake.org/cmake/help/latest/command/option.html), which contradicts it being a PATH (as described in CMake.rst). I haven't //seen// this cause problems but it might.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786