[PATCH] D86890: [compiler-rt] Remove copy of InstrProfData.inc

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 01:12:30 PDT 2020


kpdev42 added a comment.

In D86890#2270337 <https://reviews.llvm.org/D86890#2270337>, @filcab wrote:

> I would love to have a single source of truth, but this basically makes it
> impossible to just build compiler-rt by itself, no?
>
> That path is also “very non portable”, given that our cmake build system
> can find/be directed to the source for the projects in different places.
>
> Thank you,
> Filipe

Thank you for the feedback.
If it is a important case when compiler-rt should be build separately from llvm-project, 
then maybe I'll add a motivation for it to file description (like `compiler-rt should have a possibility to be built out of tree`)
and add a test to compiler-rt which will check these files to be identical?

Or it is better to leave everything as it is? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86890/new/

https://reviews.llvm.org/D86890



More information about the llvm-commits mailing list