[PATCH] D87179: Fix debug_abbrev emitter to only assign table id once

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 13 18:11:00 PDT 2020


Higuoxing accepted this revision.
Higuoxing added a comment.
This revision is now accepted and ready to land.

LGTM with nit.



================
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:834-835
             - Attribute: DW_AT_low_pc
               Form:      DW_FORM_udata
   debug_info:
     - Version:       4
----------------
May I suggest explicitly adding an empty table here? Since the size of `__debug_abbrev` section is 0x20 (32 in decimal). If the actual content size doesn't match the `size` field, `yaml2macho` usually writes random bytes to fill the gap.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87179/new/

https://reviews.llvm.org/D87179



More information about the llvm-commits mailing list