[PATCH] D87586: [X86] Improve nnan fmin/fmax vector reduction

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4809
+      // Otherwise, only NaN is a neutral element.
+      NeutralElem = DAG.getConstantFP(
+          std::numeric_limits<double>::quiet_NaN(), dl, ElemVT);
----------------
Are there tabs heres?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4822
+      // Otherwise, only NaN is a neutral element.
+      NeutralElem = DAG.getConstantFP(
+          std::numeric_limits<double>::quiet_NaN(), dl, ElemVT);
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87586/new/

https://reviews.llvm.org/D87586