[PATCH] D87585: [AMDGPU] Dynamically clear renamable to avoid constant bus errors

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 13 00:27:19 PDT 2020


critson created this revision.
critson added reviewers: rampitec, foad, arsenm.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl, qcolombet.
Herald added a project: LLVM.
critson requested review of this revision.
Herald added a subscriber: wdng.

Replace static disabling of renaming of instructions arguments
(to avoid overloading the constant bus) with dynamic clearing of
renamable flags.  This allows Machine Copy Propagation to remove
more copies, in particular on GFX10 where the constant bus is
wider.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87585

Files:
  llvm/lib/Target/AMDGPU/AMDGPU.h
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/lib/Target/AMDGPU/CMakeLists.txt
  llvm/lib/Target/AMDGPU/SIFixRenamableFlags.cpp
  llvm/lib/Target/AMDGPU/SIInstrFormats.td
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/ashr.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/extractelement-stack-lower.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/insertelement.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.image.store.2d.d16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/saddsat.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/ssubsat.ll
  llvm/test/CodeGen/AMDGPU/atomicrmw-nand.ll
  llvm/test/CodeGen/AMDGPU/ds-combine-large-stride.ll
  llvm/test/CodeGen/AMDGPU/indirect-addressing-term.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.ds.ordered.swap.ll
  llvm/test/CodeGen/AMDGPU/machine-cp-cndmask.mir
  llvm/test/CodeGen/AMDGPU/multilevel-break.ll
  llvm/test/CodeGen/AMDGPU/regbank-reassign-wave64.mir
  llvm/test/CodeGen/AMDGPU/regbank-reassign.mir
  llvm/test/CodeGen/AMDGPU/ret.ll
  llvm/test/CodeGen/AMDGPU/sgpr-spill-wrong-stack-id.mir
  llvm/test/CodeGen/AMDGPU/stack-slot-color-sgpr-vgpr-spills.mir
  llvm/test/CodeGen/AMDGPU/transform-block-with-return-to-epilog.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87585.291445.patch
Type: text/x-patch
Size: 41532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200913/19fb69b8/attachment.bin>


More information about the llvm-commits mailing list