[PATCH] D77187: [lld][WebAssembly] Add initial support for -Map/--print-map

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/MapFile.cpp:38
+namespace lld {
+namespace wasm {
+
----------------
MaskRay wrote:
> http://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions
> 
> The public functions should use the style: `void wasm::xxxxxxx`
Interesting, thanks.

I guess I should update all the source files in lld/wasm to conform.

Sadly `wasm::` is ambiguous so I had to use `llvm::wasm::`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77187/new/

https://reviews.llvm.org/D77187