[PATCH] D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D86395#2268634 <https://reviews.llvm.org/D86395#2268634>, @Jac1494 wrote:

> test53 and test55 has been removed.

We are going in circles. I'll give this 1 more try, and if it still doesn't make sense, then maybe another reviewer can better communicate what we expect for the tests:

1. There are 4 commutative patterns variations in the code.
2. Each one of those patterns should have a test (we should have at least 4 tests).
3. Each test corresponds to exactly one of the commutative patterns.
4. Each test should be in canonical form without this patch (the baseline CHECK lines should correspond exactly to the IR as written).
5. The 8 step check I provided earlier may be used to confirm that the tests provide the expected coverage for the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86395/new/

https://reviews.llvm.org/D86395