[PATCH] D87555: [DivRemPairs] Add an initial case for hoisting to a common predecessor.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 23:40:20 PDT 2020


lebedev.ri added a comment.

Can we use `DominatorTree::findNearestCommonDominator()`?
If not, please add a negative test, where it's unsafe to do so.



================
Comment at: llvm/lib/Transforms/Scalar/DivRemPairs.cpp:241
       // neither of which dominates one another.
       // FIXME: We could hoist both ops to the common predecessor block?
+
----------------
Remove FIXME?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87555/new/

https://reviews.llvm.org/D87555



More information about the llvm-commits mailing list