[PATCH] D87500: [DebugInfo] DISubrange support for fortran assumed size array

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok marked an inline comment as done.
alok added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.h:288
+  }
+  llvm_unreachable("Invalid source language");
+}
----------------
aprantl wrote:
> This would trigger an unreachable for the interval (DW_LANG_lo_user, DW_LANG_hi_user). Why not just say `default: false` instead of trying to enumerate all non-Fortran languages?
It was taken from function "isCPlusPlus", but I agree with you that it is better to return false for default and dont depend on llvm_unreachable to get assistance in adding new language enums. I shall update the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87500/new/

https://reviews.llvm.org/D87500