[PATCH] D87553: [gn] Remove unneeded MC dep from llvm-tblgen

[Reid "Away June-Sep" Kleckner via Phabricator via llvm-commits]

rnk created this revision.
rnk added reviewers: thakis, dblaikie.
Herald added a project: LLVM.
rnk requested review of this revision.

Tablegen does not have link time dependencies on MC. Having llvm-tblgen
depend on it causes it to be rebuilt in the gn build every time somebody
touches any cpp file in llvm/lib/MC* or llvm/lib/DebugInfo/Codeview*.
Touching tablegen invalidates most of the rest of the build, and
re-running it takes a while. This is is annoying for me when swapping
between branches that touch CodeView logic.

This dep was added to LLVMBuild.txt back in 2018, and presumably it was
carried over into the gn build.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87553

Files:
  llvm/utils/TableGen/LLVMBuild.txt
  llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn


Index: llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/utils/TableGen/BUILD.gn
@@ -1,7 +1,6 @@
 executable("llvm-tblgen") {
   deps = [
     "//llvm/include/llvm/Config:llvm-config",
-    "//llvm/lib/MC",
     "//llvm/lib/Support",
     "//llvm/lib/TableGen",
     "//llvm/utils/TableGen/GlobalISel",
Index: llvm/utils/TableGen/LLVMBuild.txt
===================================================================
--- llvm/utils/TableGen/LLVMBuild.txt
+++ llvm/utils/TableGen/LLVMBuild.txt
@@ -18,4 +18,4 @@
 type = BuildTool
 name = tblgen
 parent = BuildTools
-required_libraries = Support TableGen MC
+required_libraries = Support TableGen


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87553.291363.patch
Type: text/x-patch
Size: 802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200912/46e3bd66/attachment.bin>