[PATCH] D87535: [flang] Fix bug for forward referenced type

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 15:03:31 PDT 2020


PeteSteinfeld reopened this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Reopening to fix Tim's comments.



================
Comment at: flang/test/Semantics/bad-forward-type.f90:76
+  !ERROR: Derived type 't2' was used but never defined
+  !ERROR: The derived type 't2' was forward-referenced but not defined
+  implicit type(t2)(x)
----------------
tskeith wrote:
> These messages both seem to be wrong: type t2 is defined later. And they are not associated with the line that has the error.
> 
> Sorry about the late comment.
I agree.  I was focused on fixing the crash, but I should clean this up while I'm at it.  I'll reopen the revision.  Stay tuned for more changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87535/new/

https://reviews.llvm.org/D87535



More information about the llvm-commits mailing list