[PATCH] D87538: [VectorCombine] Don't vectorize scalar load under tsan

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 12:59:48 PDT 2020


MaskRay added a comment.

In D87538#2268840 <https://reviews.llvm.org/D87538#2268840>, @RKSimon wrote:

> Making general combines dependent on whether we're running sanitizers doesn't sound like a great idea - won't the impact on codegen make it trickier for sanitizers to correctly assist with identifying specific issues?

Searching for `Attribute::SanitizeThread` can reveal a few other places where certain optimizations are disabled.
For example, in Utils/VNCoercion.cpp getLoadLoadClobberFullWidthSize (testing whether a load can be widened), there is a very similar pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87538/new/

https://reviews.llvm.org/D87538



More information about the llvm-commits mailing list