[PATCH] D87529: [AArch64][GlobalISel] Refactor + improve CMN, ADDS, and ADD emit functions

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 11:52:19 PDT 2020


aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:3800
+    return emitInstr(OpcTable[1][Is32Bit], {Dst}, {LHS}, MIRBuilder, Fns);
+  return emitInstr(OpcTable[2][Is32Bit], {Dst}, {LHS, RHS}, MIRBuilder);
 }
----------------
This looks almost identical to emitADD now, can we refactor once again to keep this logic in a helper and just pass in the `OpcTable`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87529/new/

https://reviews.llvm.org/D87529



More information about the llvm-commits mailing list