[PATCH] D86071: [MLIR][OpenMP] Add omp.do operation

Fri Sep 11 02:44:50 PDT 2020

kiranchandramohan added a comment.

In D86071#2265876 <https://reviews.llvm.org/D86071#2265876>, @ftynse wrote:

>> I guess for the general workshare loop design issues we can have an RFC in discourse. But this patch can go ahead.
>
> I haven't seen answers to the questions about lowering to LLVM IR + OpenMP runtime, and it sounds suboptimal to push the patch before discussing and agreeing on the actual design.
>
> In particular, it is not clear to me how this construct will connect to loops and what the lowering flow is. Does it expect an `scf.for`/`scf.parallel` as the only nested op? Is there a plan for a separate `omp.for`? How long do loops persist when we go to LLVM, given that OpenMPIRBuilder does not handle loop constructs and we really want to avoid converting loops to CFG during MLIR->LLVM IR translation.

Thanks @ftynse for the feedback. Yes, the whole flow for the OpenMP worksharing loop requires a detailed discussion in discourse. I was only suggesting that since the operation in this patch only models what is an OpenMP do directive it can go ahead. The RFC for the workshare operation is next on @DavidTruby's list. It is fine to have the RFC discussion before submitting this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86071/new/

https://reviews.llvm.org/D86071