[PATCH] D87489: [NFC][MLInliner] Presort instruction successions.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Analysis/InlineSizeEstimatorAnalysis.cpp:141-143
   for (auto &BB : F)
     for (auto &I : BB)
       Ret += TTI.getInstructionCost(
----------------
dblaikie wrote:
> Throughout the file there are a fair few non-const references that could be const, which would be preferred. (generally top level const on local values is less interesting - but usually if a reference can be const, it should be made so)
yup - thanks, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87489/new/

https://reviews.llvm.org/D87489