[PATCH] D87021: [DebugInfo] Fix emitting DWARF64 type units (10/19).

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D87021#2254332 <https://reviews.llvm.org/D87021#2254332>, @ikudrin wrote:

> In D87021#2253899 <https://reviews.llvm.org/D87021#2253899>, @dblaikie wrote:
>
>> General feedback: If you can include the original C source code and whatever compile command was needed to generate the IR in any tests (this includes other patches I've already approved, if possible - not vital, many of the tests have very small IR that's pretty easy to read, but it's a "nice to have") that'd be handy! Makes it easier to eyeball the dump output and understand what it's expecting.
>
> The test sources were based on some simple code, but then they were cleared as much as I could.

You mean the IR was modified after compilation? Or that the original C source was simplified as much as possible?

Usually we don't simplify the IR - not worth it/doesn't make things especially more maintainable & more likely to introduce something that makes the IR quirky/not representative of the normal Clang generated IR.

> I guess they may be considered artificial. Do you think it will be beneficial to add the code like the following here?
>
>   struct Foo {int a;};
>   Foo foo;

Yep! Nice and simple bits of stuff like that are great/handy to have!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87021/new/

https://reviews.llvm.org/D87021