[PATCH] D87297: [GlobalISel] Add bailout thresholds to CSEMIRBuilder::dominates() and the localizer.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 16:58:13 PDT 2020


arsenm added a comment.

This does touch on a bug I was looking into recently. There's a bug where if you attempt to insert an instruction, and it CSEs to the instruction at the insertion point, any new uses of the return value end up getting inserted before the instruction. I think this really needs to check for properly dominates, but it seemed a lot of cases were relying on the current behavior


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87297/new/

https://reviews.llvm.org/D87297



More information about the llvm-commits mailing list