[PATCH] D87427: [GlobalISel] Add a `X, Y = G_UNMERGE(G_ZEXT Z)` -> X = G_ZEXT Z; Y = 0 combine

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 16:55:33 PDT 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nit. Could possibly use a legality check but I could't come up with an example where it would matter



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1743
+
+  Register ZeroReg = 0;
+  for (unsigned Idx = 1, EndIdx = MI.getNumDefs(); Idx != EndIdx; ++Idx) {
----------------
Don't need = 0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87427/new/

https://reviews.llvm.org/D87427



More information about the llvm-commits mailing list