[PATCH] D87286: AArch64: make sure jump table entries can reach entire image
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 10 16:52:18 PDT 2020
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM, but I still would like to see some numbers before merge.
================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:856
+ case 2: LdrOpcode = AArch64::LDRHHroX; break;
+ case 4: LdrOpcode = AArch64::LDRSWroX; break;
+ default:
----------------
efriedma wrote:
> For 32-bit, we sign-extend? I guess this is assuming a function can't be larger than 2GB? (I think you could avoid that assumption by using the compression infrastructure for 32-bit words.)
On second thought, you're likely to run into other issues well before then, so probably not important.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87286/new/
https://reviews.llvm.org/D87286
More information about the llvm-commits
mailing list