[PATCH] D87475: Use pragmas to work around MSVC x86_32 debug miscompile bug

[Reid "Away June-Sep" Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalityPredicates.cpp:13
 
+// Disable optimizations to work around MSVC debug mode bug in 32-bit:
+// https://developercommunity.visualstudio.com/content/problem/1179643/msvc-copies-overaligned-non-trivially-copyable-par.html
----------------
craig.topper wrote:
> This comment says "Disable optimizations", but the one below says "We have to disable runtime checks in order to enable optimizations". Are we enabling or disabling optimizations?
Bleh, the late breaking comment update was wrong. We are enabling optimizations. I'll fix it.

You can observe the interaction between runtime checks and optimizations on the command line with `cl -RTC1 -O2`, it will produce an error. Using pragma optimize on by itself did nothing without producing a warning. =P


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87475/new/

https://reviews.llvm.org/D87475