[PATCH] D87471: [Support] Make building with snmalloc work

Thu Sep 10 16:39:14 PDT 2020

efriedma added inline comments.

================
Comment at: llvm/lib/Support/CMakeLists.txt:256
+    add_definitions(-D_SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING)
+    if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
+      set_property(TARGET LLVMSupport PROPERTY COMPILE_FLAGS "-mcx16")
----------------
aganea wrote:
> >>! In D87471#2266274, @efriedma wrote:
> > You can't blindly specify "-mcx16" without checking the target.
> `LLVM_INTEGRATED_CRT_ALLOC` is already [[ https://github.com/llvm/llvm-project/blob/86bd8f82cc74725a08a40efe176d3d6b9c9cef92/llvm/CMakeLists.txt#L572 | Windows-only ]], even though Unix could work too (at least all three allocators support Unix). What about `if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64"` (which also accounts for ARM Windows)
Sure.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87471/new/

https://reviews.llvm.org/D87471