[PATCH] D87479: [InstCombine] Don't sink the fdiv from (fmul (fdiv 1.0, %x), %y) if the fdiv isn't in the same basic block as the fmul

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 14:29:45 PDT 2020


spatel added a comment.

This sounds very much like what happened here:
https://llvm.org/PR46115
https://github.com/JuliaLang/julia/issues/36084

So either we need a much bigger change (instcombine should not do code sinking), or we try to enforce not running instcombine after LICM somehow?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87479/new/

https://reviews.llvm.org/D87479



More information about the llvm-commits mailing list