[PATCH] D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner.

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/IROutliner.h:282
+  /// The optimization remark emitter for the pass.
+  std::function<OptimizationRemarkEmitter &(Function &)> *getORE;
+
----------------
Since this doesn't own the referred-to function, why not use an llvm::function_ref here like the others (GTTI, GIRSI)?


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1516
+                                   C->frontInstruction());
+        R << "Did not outline "
+          << ore::NV(std::to_string(CurrentGroup.Regions.size()))
----------------
FWIW, most diagnostics start with lowercase as their first letter.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1569
+        << " instructions at locations ";
+      for (OutlinableRegion *OS : CurrentGroup.Regions) {
+        R << ore::NV("DebugLoc",
----------------
llvm::interleave might help here to avoid emitting the trailing space.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87300/new/

https://reviews.llvm.org/D87300