[PATCH] D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed

[Reid "Away June-Sep" Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Makes sense.

> Unwind info for all remaining functions that hasn't gotten it emitted directly is emitted at the end.

Can we make `.seh_endproc` responsible for emitting the unwind info into `.xdata` if necessary? Would that preserve the section ordering? There is something nice about having all the .text/.pdata/.xdata sections grouped together in the object file, even though the order doesn't matter.



================
Comment at: llvm/test/CodeGen/X86/mingw-comdats.ll:81
 ; GNUOBJ: .xdata$_Z3fooi
-; GNUOBJ: .data$gv
 ; GNUOBJ: .pdata$_Z3fooi
----------------
Shouldn't this remain? This change seems unrelated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87448/new/

https://reviews.llvm.org/D87448