[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:158
+      return Entry32->ParameterHashIndex;
+    return Entry64->ParameterHashIndex;
+  }
----------------
DiggerLin wrote:
> change to 
> return Entry32 ? Entry32->ParameterHashIndex : Entry64->ParameterHashIndex
> 
> and change in the following functions too ?
I was initially worried about MSVC breakage here: https://github.com/llvm/llvm-project/commit/210314ae8c59bc0a8801c2528eda892cd5960c31
But after taking a closer look, it seems to be only a problem for conversion from ubig32_t value to a unit64_t, which does not apply here. 
So I will give it a try.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774