[PATCH] D86608: [LLD][PowerPC] Add support for R_PPC64_TPREL34 used in TLS Local Exec

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 13:45:35 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/test/ELF/ppc64-tls-pcrel-le.s:20
+
+# CHECK-LABEL: <LocalExecAddrX>:
+# CHECK:       paddi 3, 13, -28672, 0
----------------
Consider simplifying the test

```
# CHECK-LABEL: <LocalExecAddr>:
# CHECK-NEXT:    paddi 3, 13, -28672, 0
# CHECK-NEXT:    paddi 3, 13, -28668, 0
# CHECK-NEXT:    

LocalExecAddr:
  paddi 3, 13, x at TPREL, 0
  paddi 3, 13, y at TPREL, 0
  paddi 3, 13, z at TPREL+12, 0

# CHECK-LABEL: <LocalExecVal>:
# CHECK-NEXT:    ...
# CHECK-NEXT:    ...

LocalExecVal:
  paddi 3, 13, x at TPREL, 0
  lwz 3, 0(3)
  paddi 3, 13, y at TPREL, 0
  lwz 3, 0(3)
  paddi 3, 13, z at TPREL+12, 0
  lwz 3, 0(3)

```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86608/new/

https://reviews.llvm.org/D86608



More information about the llvm-commits mailing list