[PATCH] D87468: [Support] Add GlobPattern::isTrivialMatchAll()

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D87468#2266262 <https://reviews.llvm.org/D87468#2266262>, @andrewng wrote:

> In D87468#2266228 <https://reviews.llvm.org/D87468#2266228>, @MaskRay wrote:
>
>> GlobPattern::matchOne has a fast path for `'*'`. Isn't it fast enough?
>
> As mentioned in the summary, this is to avoid cost in preparing/acquiring the input, i.e. not the speed of the match but overhead related to the input.

Can you demonstrate how the old code has overhead related to the input?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87468/new/

https://reviews.llvm.org/D87468