[PATCH] D86495: [CSSPGO] MIR target-independent pseudo instruction for pseudo-probe intrinsic

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 11:03:40 PDT 2020


hoy added a comment.

In D86495#2264881 <https://reviews.llvm.org/D86495#2264881>, @wmi wrote:

> In D86495#2264877 <https://reviews.llvm.org/D86495#2264877>, @hoy wrote:
>
>> In D86495#2264868 <https://reviews.llvm.org/D86495#2264868>, @wmi wrote:
>>
>>> It is better to have a MIR test.
>>
>> Yeah, the test is actually included in https://reviews.llvm.org/D86499. It tests both the IR and MIR change.
>
> I mean to have a .mir test which read MIR as input. That is to ensure llc read MIR text containing the new pseudo probe without problem.

I see. Added a .mir test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86495/new/

https://reviews.llvm.org/D86495



More information about the llvm-commits mailing list