[PATCH] D87435: [PGO] Skip if an IndirectBrInst critical edge cannot be split

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 10:12:19 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:810
 
+  // Some IndirectBr critical edges cannot be split by the previous
+  // SplitIndirectBrCriticalEdges call. Bail out.
----------------
lebedev.ri wrote:
> s/previous/following/
I think "previous" is correct. It is `SplitIndirectBrCriticalEdges`. The function calls `SplitIndirectBrCriticalEdges` in the very beginning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87435/new/

https://reviews.llvm.org/D87435



More information about the llvm-commits mailing list