[PATCH] D86812: [DebugInstrRef][1/3] Track PHI values through register allocation

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

Just some drive-by nits while familiarizing myself with this patch series.



================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:455
+  /// pass, and emitted as DBG_PHI instructions during VirtRegRewriter, with
+  /// maintenence applied by intermediate passes that edit registers (such as
+  /// coalescing and the allocator passes).
----------------
//maintenance//.


================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:410
+  std::map<unsigned, PHIValPos> PHIValToPos;
+  // Index of, for each VReg, which debug instruction numbers and corresponding
+  /// PHIs are sensitive to splitting. Each VReg may have multiple PHI defs,
----------------
///


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1243
+      } else if (MI.isDebugPHI()) {
+        continue; // allow stack ref to continue onwards
       }
----------------
Nit: Capital letter and period.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86812/new/

https://reviews.llvm.org/D86812