[PATCH] D86071: [MLIR][OpenMP] Add omp.do operation
Alex Zinenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 10 08:54:43 PDT 2020
ftynse requested changes to this revision.
ftynse added a comment.
This revision now requires changes to proceed.
> I guess for the general workshare loop design issues we can have an RFC in discourse. But this patch can go ahead.
I haven't seen answers to the questions about lowering to LLVM IR + OpenMP runtime, and it sounds suboptimal to push the patch before discussing and agreeing on the actual design.
In particular, it is not clear to me how this construct will connect to loops and what the lowering flow is. Does it expect an `scf.for`/`scf.parallel` as the only nested op? Is there a plan for a separate `omp.for`? How long do loops persist when we go to LLVM, given that OpenMPIRBuilder does not handle loop constructs and we really want to avoid converting loops to CFG during MLIR->LLVM IR translation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86071/new/
https://reviews.llvm.org/D86071
More information about the llvm-commits
mailing list