[PATCH] D87446: [AMDGPU] Enable scheduling around FP MODE-setting instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 07:13:30 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SOPInstructions.td:847
+// register, so doesn't have unmodeled side effects.
+def S_SETMODE_B32 : SOPK_Pseudo <
+  "s_setreg_b32",
----------------
I don't like defining pseudos that look like real instruction names. I would prefer to call this something like

S_SETREG_B32_mode or something like that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87446/new/

https://reviews.llvm.org/D87446



More information about the llvm-commits mailing list