[PATCH] D87423: [GVN] Account for masked loads/stores depending on load/store instructions

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM thanks. Please run clang-format-diff before committing.



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:417
 
-      if (local_cdep->getNumArgOperands() != C->getNumArgOperands()) {
+      if (local_cdep == nullptr ||
+          local_cdep->getNumArgOperands() != C->getNumArgOperands()) {
----------------
nit: I think it is more common in this file to use `!local_cdep` instead of `local_cdefp == nullptr`.


================
Comment at: llvm/test/Transforms/GVN/masked-load-store-vn-crash.ll:5
+
+define dso_local fastcc void @test() unnamed_addr #0 {
+; CHECK-LABEL: @test(
----------------
nit: I think the `dso_local fastcc unnamed_addr #0` can eb removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87423/new/

https://reviews.llvm.org/D87423