[PATCH] D81558: [NewPM] Introduce PreserveCFG check

[Yevgeny Rouban via Phabricator via llvm-commits]

yrouban added inline comments.


================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:89
+// poisoned and no block pointer of the Graph is used.
+struct CFG {
+  struct BBGuard final : public CallbackVH {
----------------
fedor.sergeev wrote:
> Are  we ok with adding a generic 'CFG' class directly into llvm namespace by StandardInstrumentations.h?
> If it is only for CFGChecker introduced here then either put it into Checker itself or into a nested namespace named appropriately
> (e.g. cfg_checker_detail).
> 
> If you can see this class being generally useful then it deserves its own header/location.
That is why I tried introducing the class //Instrument// that would encapsulate all declarations and implementations of PrintIRInstrumentation, PrintPassInstrumentation, TimePassesHandler, OptNoneInstrumentation,  PreservedCFGCheckerInstrumentation in one cpp file :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81558/new/

https://reviews.llvm.org/D81558