[PATCH] D76434: [SCEV] Query expanded immediate cost at minsize

[Sam Parker via Phabricator via llvm-commits]

samparker marked 5 inline comments as done.
samparker added a comment.

We had gone through many revisions where I've addressed all of your (helpful) comments and I hadn't heard anything else for three weeks. I sincerely expected the remaining issues to be style changes which seem appropriate for a post-commit review.



================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:2192-2193
+    unsigned Opcode;
+    size_t MinIdx;
+    size_t MaxIdx;
+  };
----------------
lebedev.ri wrote:
> `SCEVOperand::OperandIdx` is `int`
But when we enumerate the SCEV operands, the index is size_t and the types need to be compatible for std::max and min.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76434/new/

https://reviews.llvm.org/D76434