[PATCH] D87435: [PGO] Skip if an IndirectBrInst critical edge cannot be split
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 10 00:12:09 PDT 2020
MaskRay added a comment.
In D87435#2265038 <https://reviews.llvm.org/D87435#2265038>, @lebedev.ri wrote:
> I believe every other caller ensures that as a precondition.
> Why is the existing approach incorrect, and `PGOInstrumentation` shouldn't be fixed itself?
How do other callers handle such a critical edge? `SplitCriticalEdge` is a generic API where some cases are already skipped (`return nullptr`), see isEHPad and other `return nullptr` in the function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87435/new/
https://reviews.llvm.org/D87435
More information about the llvm-commits
mailing list