[PATCH] D87199: [lld-macho] Implement support for PIC

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In D87199#2262522 <https://reviews.llvm.org/D87199#2262522>, @int3 wrote:

>> Is there a funnel point that we know that all the rebase entries will pass through to ensure that we catch them rather than adding them at a couple of sites?
>
> It may be clearer if we scan the GOT/LazyPointerSection inside `RebaseSection::finalizeContents()` for any absolute addresses, rather than relying on the code that's adding entries to either of those sections to also handle the rebasing. I will try that... however, there isn't a funnel point that will cover absolute addresses from both our SyntheticSections as well as from InputSections.

I haven't reviewed this yet so I'm missing a bunch of context, and I haven't thought through this very much yet either, but would any of this be easier if SyntheticSections were InputSections instead of OutputSections? (There's definitely downsides to that too, but it's worth thinking about the trade-offs.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199