[PATCH] D73739: Exception support for basic block sections
Di Mo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 9 15:37:19 PDT 2020
modimo added a comment.
In D73739#2264518 <https://reviews.llvm.org/D73739#2264518>, @MaskRay wrote:
> Taking a closer look at the test (haven't delved into the code yet): the PIC vs non-PIC difference of .gcc_exception_table looks strange.
> .gcc_except_table (please also test its section flags `"a"`) has an absolute relocation referencing `main.2`. This is not good. In all targets (except RISC-V -mno-relax), .gcc_except_table is a relocation-free section.
By relocation-free section do you mean all relocations or absolute relocations? This needs some type of relocation in .gcc_except_table to indicate that the landing pads are not relative to the parent function since they have been moved out.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73739/new/
https://reviews.llvm.org/D73739
More information about the llvm-commits
mailing list