[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

Wed Sep 9 15:01:07 PDT 2020

fhahn added a comment.

It looks like a recently introduced GVN crash is exposed by this change (probably D87061 <https://reviews.llvm.org/D87061>). I will commit once this is fixed.

In D87163#2263685 <https://reviews.llvm.org/D87163#2263685>, @nikic wrote:

> LGTM as well, per llvm-dev discussion. I think you've done all the due diligence we can expect.
>
> Do you plan to also work on MSSA-based MemCpyOpt? I expect that one will have a large positive impact on Rust code, where lack of cross-BB memcpy elision is a big issue right now.

I probably won't have time to work on MSSA-based MemCpyOpt for the next couple of weeks unfortunately. But I think there is a lot that can be re-used/shared from the DSE implementation. Happy to discuss approaches.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87163/new/

https://reviews.llvm.org/D87163