[PATCH] D87399: Revert "[InstCombine] erase instructions leading up to unreachable"

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 14:59:57 PDT 2020


spatel added a comment.

Admittedly, zapping stores (volatile or not) was not in the original motivation for the patch, but it seemed nice to see that enhancement. 
Reverting until things are sorted out is ok with me, but I agree with @nikic - since the LangRef is clear today about the behavior and that was hashed out on llvm-dev, somebody (not me) needs to rehash that on llvm-dev. Also, you'll need to reopen https://llvm.org/PR47416 and/or propose an alternate fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87399/new/

https://reviews.llvm.org/D87399



More information about the llvm-commits mailing list