[PATCH] D73739: Exception support for basic block sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Please see https://llvm.org/docs/GettingStarted.html#sending-patches . You'll need to upload the diff with full context.



================
Comment at: llvm/test/CodeGen/X86/gcc_except_table_bb_sections.ll:12
+; CHECK-PIC:        .cfi_personality 155, DW.ref.__gxx_personality_v0
+; CHECK-NON-PIC:    .cfi_lsda 3, .Lexception0
+; CHECK-PIC:        .cfi_lsda 27, .Lexception0
----------------
personality/lsda encodings are difficult to remember. Worth a comment like `DW_EH_PE_pcrel | DW_EH_PE_indirect | DW_EH_PE_sdata4`


================
Comment at: llvm/test/CodeGen/X86/gcc_except_table_bb_sections.ll:15
+; CHECK-LABEL:    .Ltmp0:
+; CHECK-LABEL:    .Ltmp1:
+
----------------
This is not sufficient. You need to check the next instruction to make sure things don't go off


================
Comment at: llvm/test/CodeGen/X86/gcc_except_table_bb_sections.ll:19
+
+; CHECK-LABEL:    main.1:
+; CHECK:            .cfi_startproc
----------------
If you use `main.1` `main.2` etc, you will waste a lot of space in `.strtab`. Better using a unary encoding or a temporary label (`.L` in ELF)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739