[PATCH] D87381: [LLD][PowerPC][test] Add test cases for all pc-rel based stubs when the offset not fit in 34 bits

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 14:08:34 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/ELF/Thunks.cpp:913
   if (!isInt<34>(offset))
-    fatal("offset must fit in 34 bits to encode in the instruction");
+    fatal("offset overflow 34 bits, please compile using the large code model");
   uint64_t paddi = PADDI_R12_NO_DISP | (((offset >> 16) & 0x3ffff) << 32) |
----------------
We have an existing diagnostic like

`error: relocation R_AARCH64_ABS32 cannot be used against symbol hidden; recompile with -fPIC`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87381/new/

https://reviews.llvm.org/D87381



More information about the llvm-commits mailing list