[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 14:04:34 PDT 2020


vsk added a comment.

In D84988#2264199 <https://reviews.llvm.org/D84988#2264199>, @zequanwu wrote:

> Thanks for reviewing. One last thing I need to resolve is to handle the coverage test case as skipped regions are emitted for empty lines, and haven't thought a good way other than adding checks for those new skipped regions.

How does it sound to add a testing-only cl::opt that disables whitespace skipped regions? Tests that aren't focused on validating skipped regions can set this cl::opt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84988/new/

https://reviews.llvm.org/D84988



More information about the llvm-commits mailing list