[PATCH] D83465: Encode alignment attribute for `atomicrmw`

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:5083
+      if (Record.size() == 7)
+        Alignment = Align(1ULL << Record[6]);
+      else
----------------
jfb wrote:
> I think you want this instead:
> ```
> 
>       MaybeAlign Align;
>       if (Error Err = parseAlignmentValue(Record[6], Align))
>         return Err;
> ```
> ?
Absolutely!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83465/new/

https://reviews.llvm.org/D83465