[PATCH] D73739: Exception support for basic block sections

[Di Mo via Phabricator via llvm-commits]

modimo added a comment.

In D73739#2261537 <https://reviews.llvm.org/D73739#2261537>, @snehasish wrote:

> Once this patch is in we can look into splitting ehpads out though I'm more inclined to enhance the static profile count mechanism to account for ehpads appropriately rather than adding a new flag to MFS.

On this front, is there a specific reviewer that we're waiting for here to get this change through?

> In general, it would be great to have MFS operate with only the knowledge of profiles counts rather than special-casing for particular types of blocks.

Splitting out EH pads in my experience is always a net gain or at least neutral in all aspects of code size/performance. I expect static and dynamic counts in general will require rounds of tuning and will still hit pathological cases on certain scenarios. Taken together enabling a scenario where only EH pads are split out is valuable since this can safely be enabled as a default optimization behavior. As a reference point MSVC does by default split out the its EH pad equivalents into cold code as part of its general `-O2` optimizations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739