[PATCH] D87045: [LoopNest] Handle loop-nest passes in LoopPassManager

[Ta-Wei Tu via Phabricator via llvm-commits]

TaWeiTu marked 5 inline comments as done.
TaWeiTu added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:178
+  BitVector PassCategories;
+  std::vector<std::unique_ptr<LoopPassConceptT>> LoopPasses;
+  std::vector<std::unique_ptr<LoopNestPassConceptT>> LoopNestPasses;
----------------
Whitney wrote:
> can we use llvm data structures here?
Since this is a specialized version of `PassManager` and `PassManager` uses `std::vector` instead of the LLVM data structures, I'm not sure which one is better here.


================
Comment at: llvm/unittests/Transforms/Scalar/LoopPassManagerTest.cpp:1599
+
+TEST_F(LoopPassManagerTest, HandleLoopNestPass) {
+  ::testing::InSequence MakeExpectationsSequenced;
----------------
etiotto wrote:
> `HandleLoopNestPass` isn't used. How does this test work?
I'm not sure what this means actually because I suppose this is how GoogleTest works and the test does run. Do you mean that I should add some comments to illustrate what functionality is the unittest testing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87045/new/

https://reviews.llvm.org/D87045