[PATCH] D87392: [JumpThreading] Fix an incorrect Modified status

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 11:59:20 PDT 2020


efriedma added a comment.

> I assume that we in such cases don't want to return true from ProcessBlock(), which would trigger another iteration of the function.

Theoretically, it's unnecessary, so we'd want to avoid it the extra analysis cost.  But in practice this should be really rare, so I'd prefer to keep the code simpler and continue using a bool return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87392/new/

https://reviews.llvm.org/D87392



More information about the llvm-commits mailing list