[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

[Mark de Wever via Phabricator via llvm-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: clang/include/clang/AST/Stmt.h:1180
+
+  /// \returns the likelihood of the branches of an if statement.
+  static Likelihood getLikelihood(const Stmt *Then, const Stmt *Else);
----------------
Quuxplusone wrote:
> Mordante wrote:
> > aaron.ballman wrote:
> > > This only returns one value, so it can't return the likelihood of "the branches". How about something along the lines of:
> > > 
> > > `returns the likelihood of the 'then' branch of an 'if' statement. The 'else' branch is required to determine whether both branches specify the same likelihood, which impacts the result.`
> > Good catch, I'll use your suggestion.
> s/impacts/affects/ ;)
Just in time before I commit this patch :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85091/new/

https://reviews.llvm.org/D85091